-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSIP40 Implementation #1860
BSIP40 Implementation #1860
Conversation
1a44ac2
to
fc168ec
Compare
Fortunately we only have
The front-end usually doesn't calculate fees by their own but simply calls |
Vectors are used in several operations. Mostly |
7934387
to
ae03233
Compare
a442c84
to
8327d3a
Compare
libraries/chain/include/graphene/chain/custom_authority_object.hpp
Outdated
Show resolved
Hide resolved
libraries/protocol/custom_authorities/restriction_predicate.hxx
Outdated
Show resolved
Hide resolved
libraries/protocol/custom_authorities/restriction_predicate.hxx
Outdated
Show resolved
Hide resolved
Just some typo fixes
BSIP 40: Unit tests
@MichelSantos has brought up an interesting point: the current spec/implementation does not really provide a way to restrict that a container field have only values selected from a defined list. The logical way to do this would be to allow the With a slightly loose interpretation of the wording, the spec supports this. Shall I add this functionality to the implementation? |
Changes requested so far have been applied. |
I tend to leaving this for a later release. Unsure though. I guess it's a small change only, but OTOH I can't imagine where it'd be useful. |
It is fairly straightforward to add, yeah. Michel was attempting to test a case where someone wants to set a custom authority that can appoint feed producers for an asset from an authorized list. I'm not sure how useful that is in real life, but it's an illustrative example. |
dfab0ee
to
51da97d
Compare
Add specializations to allow `in` and `not_in` restrictions to operate on all values in a container field
I've added the specializations, but I can remove them if they are not desired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, thanks!
Awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiled on Ubutntu 18.04 / Boost 1.65.1 / OpenSSL 1.1.1. chain_tests ran without errors. Code looks good.
Yay!...this once lowly issue: #1061 led to this :) Somewhat proud despite not actually having done much :D |
My implementation for BSIP 40, Custom Active Authorities
A couple of notes:
flat_set<T>
against avector<T>
, for instance, doesn't work.